From: umherirrender Date: Tue, 27 Nov 2012 20:49:58 +0000 (+0100) Subject: RefreshLinksJob parsed with incorrect revision variables X-Git-Tag: 1.31.0-rc.0~21492 X-Git-Url: http://git.cyclocoop.org/%22.%24info%5B?a=commitdiff_plain;h=472f0ecaca2105c18e0aad1c7f4d46ef2dea72ee;p=lhc%2Fweb%2Fwiklou.git RefreshLinksJob parsed with incorrect revision variables It is necessary to pass the revision id to the parser output to get the revision variables like REVISIONTIMESTAMP correct. Doing this self in the job prevents from calling Title::getLatestRevId in Content::getSecondaryDataUpdates or other places. This behaviour was lost in I551a90b0 Change-Id: I4bf0e8199edacaa703699f45ec8e65ca9e31e765 --- diff --git a/includes/job/jobs/RefreshLinksJob.php b/includes/job/jobs/RefreshLinksJob.php index 384244fbad..86c808bb9f 100644 --- a/includes/job/jobs/RefreshLinksJob.php +++ b/includes/job/jobs/RefreshLinksJob.php @@ -78,7 +78,10 @@ class RefreshLinksJob extends Job { $content = $revision->getContentHandler()->makeEmptyContent(); } - $updates = $content->getSecondaryDataUpdates( $title, null, false ); + // Revision ID must be passed to the parser output to get revision variables correct + $parserOutput = $content->getParserOutput( $title, $revision->getId(), null, false ); + + $updates = $content->getSecondaryDataUpdates( $title, null, false, $parserOutput ); DataUpdate::runUpdates( $updates ); wfProfileOut( $fname ); }